Messages in this thread Patch in this message | | | From | Julia Lawall <> | Subject | [PATCH 2/2] video: delete unneeded call to platform_get_drvdata | Date | Sat, 17 May 2014 08:32:49 +0200 |
| |
From: Julia Lawall <Julia.Lawall@lip6.fr>
Platform_get_drvdata is an accessor function, and has no purpose if its result is not used.
The semantic patch that fixes this problem is as follows: (http://coccinelle.lip6.fr/)
// <smpl> @@ identifier x; type T; @@ - T x = platform_get_drvdata(...); ... when != x // </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
--- drivers/video/fbdev/bf54x-lq043fb.c | 2 -- 1 file changed, 2 deletions(-)
diff --git a/drivers/video/fbdev/bf54x-lq043fb.c b/drivers/video/fbdev/bf54x-lq043fb.c index e2c42ad..adbef54 100644 --- a/drivers/video/fbdev/bf54x-lq043fb.c +++ b/drivers/video/fbdev/bf54x-lq043fb.c @@ -717,8 +717,6 @@ static int bfin_bf54x_remove(struct platform_device *pdev) #ifdef CONFIG_PM static int bfin_bf54x_suspend(struct platform_device *pdev, pm_message_t state) { - struct fb_info *fbinfo = platform_get_drvdata(pdev); - bfin_write_EPPI0_CONTROL(bfin_read_EPPI0_CONTROL() & ~EPPI_EN); disable_dma(CH_EPPI0); bfin_write_EPPI0_STATUS(0xFFFF);
| |