lkml.org 
[lkml]   [2014]   [May]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v3 1/3] phy: Add exynos-simple-phy driver
From
Hi,

On 15 May 2014 19:01, Bartlomiej Zolnierkiewicz
<b.zolnierkie@samsung.com> wrote:
>
> Hi,
>
> On Thursday, May 15, 2014 12:47:21 AM Rahul Sharma wrote:
>> From: Tomasz Stanislawski <t.stanislaws@samsung.com>
>>
>> Add exynos-simple-phy driver to support a single register
>> PHY interfaces present on Exynos4 SoC.
>>
>> Signed-off-by: Tomasz Stanislawski <t.stanislaws@samsung.com>
>> Signed-off-by: Rahul Sharma <Rahul.Sharma@samsung.com>
>>
>> ---
>> .../devicetree/bindings/phy/samsung-phy.txt | 56 ++++++
>> drivers/phy/Kconfig | 5 +
>> drivers/phy/Makefile | 1 +
>> drivers/phy/exynos-simple-phy.c | 189 ++++++++++++++++++++
>> include/dt-bindings/phy/exynos-simple-phy.h | 27 +++
>> 5 files changed, 278 insertions(+)
>> create mode 100644 drivers/phy/exynos-simple-phy.c
>> create mode 100644 include/dt-bindings/phy/exynos-simple-phy.h
>
> [...]
>
>> diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
>> index 16a2f06..2a13e0d 100644
>> --- a/drivers/phy/Kconfig
>> +++ b/drivers/phy/Kconfig
>> @@ -178,4 +178,9 @@ config PHY_XGENE
>> help
>> This option enables support for APM X-Gene SoC multi-purpose PHY.
>>
>> +config EXYNOS_SIMPLE_PHY
>> + tristate "Exynos Simple PHY driver"
>
> Please limit this driver to EXYNOS platforms with:
>
> depends on ARCH_EXYNOS
>
> or (optionally)
>
> depends on ARCH_EXYNOS || COMPILE_TEST
>
> Moreover the generic PHY dependency is missing. It can be fixed with:
>
> select GENERIC_PHY
>

Yea, I will fix this part.

Regards,
Rahul Sharma.

>> + help
>> + Support for 1-bit PHY controllers on SoCs from Exynos family.
>> +
>> endmenu
>
> Best regards,
> --
> Bartlomiej Zolnierkiewicz
> Samsung R&D Institute Poland
> Samsung Electronics
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html


\
 
 \ /
  Last update: 2014-05-17 13:41    [W:0.101 / U:0.732 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site