lkml.org 
[lkml]   [2014]   [May]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH v3 1/3] phy: Add exynos-simple-phy driver
    From
    Thanks Tomasz,

    On 15 May 2014 01:31, Tomasz Figa <tomasz.figa@gmail.com> wrote:
    > Hi Rahul, Tomasz,
    [snip]
    >> + simplephys: simple-phys@10040000 {
    >> + compatible = "samsung,exynos5250-simple-phy";
    >
    > Missing reg property or unnecessary @unit-address suffix in node name.

    I should have removed "@unit-address". I will change this.

    >
    >> + samsung,pmu-syscon = <&pmu_system_controller>;
    >> + #phy-cells = <1>;
    >> + };
    >
    > In general, the idea is quite good, but I think this should rather bind
    > to the main PMU node, since this is just a part of the PMU, not another
    > device in the system. This also means that the PMU node itself should be
    > the PHY provider.
    >

    Please correct me if I got you wrong. You want somthing like this:

    pmu_system_controller: system-controller@10040000 {
    ...
    simple_phys: simple-phys {
    compatible = "samsung,exynos5420-simple-phy";
    ...
    };
    };

    Regards,
    Rahul Sharma.

    > Otherwise looks good.
    >
    > Best regards,
    > Tomasz
    > _______________________________________________
    > dri-devel mailing list
    > dri-devel@lists.freedesktop.org
    > http://lists.freedesktop.org/mailman/listinfo/dri-devel


    \
     
     \ /
      Last update: 2014-05-15 06:44    [W:4.066 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site