Messages in this thread | | | Date | Thu, 15 May 2014 09:31:07 +0530 | Subject | Re: [PATCH v3 1/3] phy: Add exynos-simple-phy driver | From | Rahul Sharma <> |
| |
Thanks Tomasz,
On 15 May 2014 01:31, Tomasz Figa <tomasz.figa@gmail.com> wrote: > Hi Rahul, Tomasz, [snip] >> + simplephys: simple-phys@10040000 { >> + compatible = "samsung,exynos5250-simple-phy"; > > Missing reg property or unnecessary @unit-address suffix in node name.
I should have removed "@unit-address". I will change this.
> >> + samsung,pmu-syscon = <&pmu_system_controller>; >> + #phy-cells = <1>; >> + }; > > In general, the idea is quite good, but I think this should rather bind > to the main PMU node, since this is just a part of the PMU, not another > device in the system. This also means that the PMU node itself should be > the PHY provider. >
Please correct me if I got you wrong. You want somthing like this:
pmu_system_controller: system-controller@10040000 { ... simple_phys: simple-phys { compatible = "samsung,exynos5420-simple-phy"; ... }; };
Regards, Rahul Sharma.
> Otherwise looks good. > > Best regards, > Tomasz > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel
| |