lkml.org 
[lkml]   [2014]   [May]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 06/20] perf tools: Consolidate output field handling to hpp format routines
On Mon, May 12, 2014 at 03:28:39PM +0900, Namhyung Kim wrote:

SNIP

> - }
> -
> if (symbol_conf.use_callchain && sort__has_sym) {
> if (callchain_param.mode == CHAIN_GRAPH_REL)
> total = h->stat.period;
> diff --git a/tools/perf/ui/hist.c b/tools/perf/ui/hist.c
> index c65a7fd744c6..32d2dfd794d9 100644
> --- a/tools/perf/ui/hist.c
> +++ b/tools/perf/ui/hist.c
> @@ -352,8 +352,18 @@ LIST_HEAD(perf_hpp__sort_list);
> #undef __HPP_ENTRY_RAW_FN
>
>
> +void perf_hpp__setup_output_field(void);

should go to util/hist.h

jirka

> {
> diff --git a/tools/perf/ui/stdio/hist.c b/tools/perf/ui/stdio/hist.c
> index 9eccf7f4f367..e6920d124c60 100644
> --- a/tools/perf/ui/stdio/hist.c
> +++ b/tools/perf/ui/stdio/hist.c
> @@ -353,8 +353,7 @@ static int hist_entry__fprintf(struct hist_entry *he, size_t size,
> if (size == 0 || size > bfsz)
> size = hpp.size = bfsz;
>
> - ret = hist_entry__period_snprintf(&hpp, he);
> - hist_entry__sort_snprintf(he, bf + ret, size - ret, hists);
> + hist_entry__period_snprintf(&hpp, he);

so it's no longer just period.. should we rename it? like
hist_entry__hpp_snprintf
hist_entry__snprintf

jirka


\
 
 \ /
  Last update: 2014-05-15 15:01    [W:0.452 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site