Messages in this thread | | | Date | Thu, 15 May 2014 14:11:52 +0200 | From | Jiri Olsa <> | Subject | Re: [PATCH 06/20] perf tools: Consolidate output field handling to hpp format routines |
| |
On Mon, May 12, 2014 at 03:28:39PM +0900, Namhyung Kim wrote:
SNIP
> diff --git a/tools/perf/ui/stdio/hist.c b/tools/perf/ui/stdio/hist.c > index 9eccf7f4f367..e6920d124c60 100644 > --- a/tools/perf/ui/stdio/hist.c > +++ b/tools/perf/ui/stdio/hist.c > @@ -353,8 +353,7 @@ static int hist_entry__fprintf(struct hist_entry *he, size_t size, > if (size == 0 || size > bfsz) > size = hpp.size = bfsz; > > - ret = hist_entry__period_snprintf(&hpp, he); > - hist_entry__sort_snprintf(he, bf + ret, size - ret, hists); > + hist_entry__period_snprintf(&hpp, he);
hm, how about hist_browser__fprintf_entry.. looks like it could use just hist_entry__period_snprintf as well and we could get rid hist_entry__sort_snprintf completely
thanks, jirka
| |