lkml.org 
[lkml]   [2014]   [May]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] lib/crc7: Shift crc7() output left 1 bit
On Sun 2014-05-11 05:16:07, George Spelvin wrote:
> > Looks good, but should not function name change when functionality got
> > completely different?
>
> I couldn't think of one. Can you?
>
> I suppose adding a _be (big-endian) suffix would be consistent.
> Is that okay with you?
>
> To do it properly, I have to rename all of:
>
> crc7_syndrome_table[]
> crc7_byte()
> crc7()
>
> even though the third is the only (in-tree) user of the first two.

If the first two are static, there's no problem.

Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html


\
 
 \ /
  Last update: 2014-05-14 22:41    [W:1.177 / U:0.160 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site