Messages in this thread | | | Date | Wed, 14 May 2014 21:56:57 +0200 | From | Pavel Machek <> | Subject | Re: [PATCH] lib/crc7: Shift crc7() output left 1 bit |
| |
On Sun 2014-05-11 05:16:07, George Spelvin wrote: > > Looks good, but should not function name change when functionality got > > completely different? > > I couldn't think of one. Can you? > > I suppose adding a _be (big-endian) suffix would be consistent. > Is that okay with you? > > To do it properly, I have to rename all of: > > crc7_syndrome_table[] > crc7_byte() > crc7() > > even though the third is the only (in-tree) user of the first two.
If the first two are static, there's no problem.
Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
| |