Messages in this thread | | | Date | Sun, 11 May 2014 12:36:02 +0200 | From | Pavel Machek <> | Subject | Re: [PATCH 3/3] drivers/net/wireless/ti/wl*/spi.c: Simplify CRC computation |
| |
On Sun 2014-05-11 06:07:43, George Spelvin wrote: > These devices require commands stored in buffers in an odd order, > different from that in which the CRC is computed. > > Rather than make two copies of the commands in two different orders, > form the commands in logical (CRC) order, append the CRC, then byte-swap > in place to the desired order. > > The old code worked fine, I'm just scratching an "ugh, that's ugly" > itch. > > Signed-off-by: George Spelvin <linux@horizon.com>
Reviewed-by: Pavel Machek <pavel@ucw.cz>
-- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
| |