| Date | Wed, 14 May 2014 21:34:34 +0200 | Subject | Re: [PATCH 13/27] m68k: Use common bits from generic tlb.h | From | Geert Uytterhoeven <> |
| |
Hi Richard,
On Wed, May 14, 2014 at 9:26 PM, Richard Weinberger <richard@nod.at> wrote: >> But why this sudden #ifdef checks? > > They are needed because in pgalloc.h you have: > #ifdef CONFIG_MMU > #include <asm/virtconvert.h> > #if defined(CONFIG_COLDFIRE) > #include <asm/mcf_pgalloc.h> > #elif defined(CONFIG_SUN3) > #include <asm/sun3_pgalloc.h> > #else > #include <asm/motorola_pgalloc.h> > #endif > > And only asm/motorola_pgalloc.h have __pte/pmd_free_tlb as static inline functions. > Therefore we need to define them such that the generic tlb.h versions will not clash > with yours.
Thanks for the clarification!
Perhaps this deserves a comment:
/* Applies to Classic m68k MMU only */
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
|