lkml.org 
[lkml]   [2014]   [May]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 16/27] mips: Use common bits from generic tlb.h
    Am 15.05.2014 20:02, schrieb Leonid Yegoshin:
    > On 05/14/2014 11:59 AM, Richard Weinberger wrote:
    >> It is no longer needed to define them on our own.
    >>
    >> Cc: Ralf Baechle <ralf@linux-mips.org>
    >> Cc: John Crispin <blogic@openwrt.org>
    >> Cc: Markos Chandras <markos.chandras@imgtec.com>
    >> Cc: Leonid Yegoshin <Leonid.Yegoshin@imgtec.com>
    >> Cc: Richard Weinberger <richard@nod.at>
    >> Cc: linux-mips@linux-mips.org
    >> Cc: linux-kernel@vger.kernel.org
    >> Signed-off-by: Richard Weinberger <richard@nod.at>
    >> ---
    >> arch/mips/include/asm/tlb.h | 7 -------
    >> 1 file changed, 7 deletions(-)
    >>
    >> diff --git a/arch/mips/include/asm/tlb.h b/arch/mips/include/asm/tlb.h
    >> index 4a23493..5ea43ca 100644
    >> --- a/arch/mips/include/asm/tlb.h
    >> +++ b/arch/mips/include/asm/tlb.h
    >> @@ -10,13 +10,6 @@
    >> if (!tlb->fullmm) \
    >> flush_cache_range(vma, vma->vm_start, vma->vm_end); \
    >> } while (0)
    >> -#define tlb_end_vma(tlb, vma) do { } while (0)
    >> -#define __tlb_remove_tlb_entry(tlb, ptep, address) do { } while (0)
    >> -
    >> -/*
    >> - * .. because we flush the whole mm when it fills up.
    >> - */
    >> -#define tlb_flush(tlb) flush_tlb_mm((tlb)->mm)
    >> #define UNIQUE_ENTRYHI(idx) \
    >> ((CKSEG0 + ((idx) << (PAGE_SHIFT + 1))) | \
    >
    > I would like to know why these functions are eliminated (don't find any clue).
    > Is it just because there will be a generic one or the calls would be eliminated?

    There will be a generic one.
    See [PATCH 03/27] generic/tlb.h: Move common defines into generic tlb.h

    > And if there are generic - can I tune it later?

    Yes. You can always define your own and override the generic one.

    Thanks,
    //richard


    \
     
     \ /
      Last update: 2014-05-15 21:01    [W:4.839 / U:0.068 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site