Messages in this thread | | | Date | Sun, 11 May 2014 19:20:58 -0700 | From | Guenter Roeck <> | Subject | Re: [lm-sensors] [PATCH] drivers/hwmon/emc1403.c: add support for emc1412 |
| |
On 05/11/2014 03:40 PM, Guenter Roeck wrote: [ ... ]
>> >> id = i2c_smbus_read_byte_data(client, THERMAL_REVISION_REG); >> - if (id != 0x01) >> + if (id != 0x01 && id != 0x04) { >> return -ENODEV; > > This should be a separate patch, as it applies to emc1403/emc1404 as well, > so we can backport it into -stable. >
Also, the chip datasheet suggests that chip revision 3 exists as well. Given that, I would suggest to replace the revision number check with something like if (id < 0x01 || id > 0x04) return -ENODEV;
Guenter
| |