Messages in this thread | | | Date | Sun, 11 May 2014 15:47:17 -0700 | From | Guenter Roeck <> | Subject | Re: [PATCH] drivers/hwmon/emc1403.c: add support for emc1412 |
| |
On 05/11/2014 06:00 AM, Josef Gajdusek wrote: > Adds support for emc1412. > [ ... ] > @@ -330,9 +389,9 @@ static int emc1403_detect(struct i2c_client *client, > } > > id = i2c_smbus_read_byte_data(client, THERMAL_REVISION_REG); > - if (id != 0x01) > + if (id != 0x01 && id != 0x04) { > return -ENODEV; > - > + }
Forgot: Please see Documents/CodingStyle, Chapter 3:
"Do not unnecessarily use braces where a single statement will do."
As it turns out, this change generates a checkpatch warning.
Also, you forgot to sign this patch.
Guenter
| |