Messages in this thread Patch in this message | | | Date | Thu, 01 May 2014 13:21:47 +0400 | From | Kirill Tkhai <> | Subject | [RFC] rtmutex: Do not boost fair tasks each other |
| |
Higher priority does not provide exclusive privilege of one fair task over the other. In this case priority boosting looks excess.
On RT patch with enabled PREEMPT_RT_FULL I see a lot of rt_mutex_setprio() actions like
120 -> 118 118 -> 120
They harm RT tasks.
RT patch has lazy preemtion feature, so if idea is we care about excess preemption inside fair class, we should care about excess priority inheritance too.
In case of vanila kernel the problem is the same, but there are no so many rt mutexes. Do I skip anything?
Kirill --- kernel/locking/rtmutex.c | 21 ++++++++++++++------- 1 file changed, 14 insertions(+), 7 deletions(-)
diff --git a/kernel/locking/rtmutex.c b/kernel/locking/rtmutex.c index aa4dff0..609a57e 100644 --- a/kernel/locking/rtmutex.c +++ b/kernel/locking/rtmutex.c @@ -197,11 +197,14 @@ rt_mutex_dequeue_pi(struct task_struct *task, struct rt_mutex_waiter *waiter) */ int rt_mutex_getprio(struct task_struct *task) { - if (likely(!task_has_pi_waiters(task))) - return task->normal_prio; + if (unlikely(task_has_pi_waiters(task))) { + int prio = task_top_pi_waiter(task)->prio; + + if (rt_prio(prio) || dl_prio(prio)) + return min(prio, task->normal_prio); + }
- return min(task_top_pi_waiter(task)->prio, - task->normal_prio); + return task->normal_prio; }
struct task_struct *rt_mutex_get_top_task(struct task_struct *task) @@ -218,10 +221,14 @@ struct task_struct *rt_mutex_get_top_task(struct task_struct *task) */ int rt_mutex_check_prio(struct task_struct *task, int newprio) { - if (!task_has_pi_waiters(task)) - return 0; + if (unlikely(task_has_pi_waiters(task))) { + int prio = task_top_pi_waiter(task)->task->prio;
- return task_top_pi_waiter(task)->task->prio <= newprio; + if (rt_prio(prio) || dl_prio(prio)) + return prio <= newprio; + } + + return 0; }
/*
| |