Messages in this thread | | | Date | Fri, 4 Apr 2014 19:54:52 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH v8 01/10] qspinlock: A generic 4-byte queue spinlock implementation |
| |
* Waiman Long <waiman.long@hp.com> wrote:
> On 04/04/2014 12:57 PM, Konrad Rzeszutek Wilk wrote: > >On Fri, Apr 04, 2014 at 03:00:12PM +0200, Peter Zijlstra wrote: > >>So I'm just not ever going to pick up this patch; I spend a week trying > >>to reverse engineer this; I posted a 7 patch series creating the > >>equivalent, but in a gradual and readable fashion: > >> > >> http://lkml.kernel.org/r/20140310154236.038181843@infradead.org > >> > >>You keep on ignoring that; I'll keep on ignoring your patches. > >> > >>I might at some point rewrite some of your pv stuff on top to get this > >>moving again, but I'm not really motivated to work with you atm. > >Uh? Did you CC also xen-devel@lists.xenproject.org on your patches Peter? > >I hadn't had a chance to see or comment on them :-( > > > > Peter's patch is a rewrite of my patches 1-4, there is no PV or > unfair lock support in there.
It is a fine grained split-up, which does one thing at a time, so it all becomes reviewable and mergable (and the claimed effects become testable!). Please use that as a base.
Thanks,
Ingo
| |