Messages in this thread Patch in this message | | | From | Leon Ma <> | Subject | [PATCH] hrtimer:do not start hrtimer on other cpu if it is the leftmost timer. | Date | Wed, 30 Apr 2014 16:43:10 +0800 |
| |
On SMP system, if cpuX is idle and it starts an hrtimer, the timer will be started on cpuY. But it can not reprogram the event source on cpuY. The timer is inserted into rb tree of cpuY, if it is the leftmost timer on cpuY and it is a very short timer, following hrtimers started on cpuY will also not set the event source. As a result, the timers on cpuY will expire later than expected.
When this case is detected, we should start the timer on cpuX and program event source properly.
Signed-off-by: Leon Ma <xindong.ma@intel.com> --- kernel/hrtimer.c | 5 +++++ 1 file changed, 5 insertions(+)
diff --git a/kernel/hrtimer.c b/kernel/hrtimer.c index d55092c..68becbc 100644 --- a/kernel/hrtimer.c +++ b/kernel/hrtimer.c @@ -234,6 +234,11 @@ again: goto again; } timer->base = new_base; + } else { + if (cpu != this_cpu && hrtimer_check_target(timer, new_base)) { + cpu = this_cpu; + goto again; + } } return new_base; } -- 1.7.9.5
| |