Messages in this thread Patch in this message | | | Date | Tue, 29 Apr 2014 18:49:47 +0900 | From | Daeseok Youn <> | Subject | [PATCH] firewire: fix NULL derefencing in fwnet_probe() |
| |
"dev" and "net" are NULL when alloc_netdev() is failed. So just unlock and return an error.
Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com> --- drivers/firewire/net.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/firewire/net.c b/drivers/firewire/net.c index 4af0a7b..c398645 100644 --- a/drivers/firewire/net.c +++ b/drivers/firewire/net.c @@ -1462,8 +1462,8 @@ static int fwnet_probe(struct fw_unit *unit, net = alloc_netdev(sizeof(*dev), "firewire%d", fwnet_init_dev); if (net == NULL) { - ret = -ENOMEM; - goto out; + mutex_unlock(&fwnet_device_mutex); + return -ENOMEM; } allocated_netdev = true; -- 1.7.4.4
| |