| Date | Sun, 27 Apr 2014 15:51:36 +0200 | From | Oleg Nesterov <> | Subject | Re: [PATCH 0/4] uprobes/x86: UPROBE_FIX_IP/UPROBE_FIX_CALL cleanups |
| |
On 04/25, Oleg Nesterov wrote: > > Jim, I see your email about the previous series. If we rename ->def then > this series obviously should be updated too, but this is trivial.
Better yet, can't we rename it in a separate patch?
I agree, ->def doesn't look good. So far I am inclined to make it ->dflt, although let me repeat I agree with any naming and I can use "dfault" as you suggested.
But. If we rename it, then we should probably also rename default_xol_ops and its methods accordingly, and I think that "cosmetic, renames only" patch makes more sense.
OK?
Oleg.
|