Messages in this thread | ![/](/images/icornerl.gif) | | Date | Tue, 29 Apr 2014 15:36:11 +0530 | From | Srikar Dronamraju <> | Subject | Re: [PATCH 4/5] uprobes/x86: Make good_insns_* depend on CONFIG_X86_* |
| |
* Oleg Nesterov <oleg@redhat.com> [2014-04-19 19:01:59]:
> Add the suitable ifdef's around good_insns_* arrays. We do not want > to add the ugly ifdef's into their only user, uprobe_init_insn(), so > the "#else" branch simply defines them as NULL. This doesn't generate > the extra code, gcc is smart enough, although the code is fine even if > it could not detect that (without CONFIG_IA32_EMULATION) is_64bit_mm() > is __builtin_constant_p(). > > The patch looks more complicated because it also moves good_insns_64 > up close to good_insns_32. > > Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Acked-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
> --- -- Thanks and Regards Srikar Dronamraju
| ![\](/images/icornerr.gif) |