Messages in this thread Patch in this message | | | From | Oren Twaig <> | Subject | [PATCH v2] X86: Hook apic vector allocation domain only when interrupt routing are set to ignore | Date | Fri, 25 Apr 2014 00:52:06 +0300 |
| |
vSMP Foundation provides locality based interrupt routing which needed vector_allocation_domain to allow all online cpus can handle all possible vectors.
Enforcing Interrupt Routing Comply (IRC) mode requires us to unplug this hook as otherwise the IOAPIC, MSI and MSIX destination selectors to always select the lowest online cpu as the destination. I.e affinity of HW interrupts cannot be controled by kernel and/or userspace code.
The purpose of the patch is to fix the code to set override vector allocation domain only when IRC is set to ignore to allow the kernel and userspace to effectively control the destination of the HW interrupts.
Signed-off-by: Oren Twaig <oren@scalemp.com> Acked-by: Shai Fultheim <shai@scalemp.com> ---
arch/x86/kernel/vsmp_64.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/arch/x86/kernel/vsmp_64.c b/arch/x86/kernel/vsmp_64.c index f6584a9..b7f8e5b 100644 --- a/arch/x86/kernel/vsmp_64.c +++ b/arch/x86/kernel/vsmp_64.c @@ -26,6 +26,8 @@ #define TOPOLOGY_REGISTER_OFFSET 0x10 +static int irc = 1; + #if defined CONFIG_PCI && defined CONFIG_PARAVIRT /* * Interrupt control on vSMPowered systems: @@ -101,6 +103,10 @@ static void __init set_vsmp_pv_ops(void) #ifdef CONFIG_SMP if (cap & ctl & BIT(8)) { ctl &= ~BIT(8); + + /* Interrupt routing set to ignore */ + irc = 0; + #ifdef CONFIG_PROC_FS /* Don't let users change irq affinity via procfs */ no_irq_affinity = 1; @@ -218,7 +224,9 @@ static void vsmp_apic_post_init(void) { /* need to update phys_pkg_id */ apic->phys_pkg_id = apicid_phys_pkg_id; - apic->vector_allocation_domain = fill_vector_allocation_domain; + + if (!irc) + apic->vector_allocation_domain = fill_vector_allocation_domain; } void __init vsmp_init(void)
| |