Messages in this thread | | | Date | Tue, 22 Apr 2014 23:23:33 +0200 | From | Frederic Weisbecker <> | Subject | Re: [PATCH V2 01/19] tick: trivial cleanups |
| |
On Mon, Apr 21, 2014 at 03:24:57PM +0530, Viresh Kumar wrote: > diff --git a/kernel/time/tick-sched.c b/kernel/time/tick-sched.c > index 6558b7a..9e9ddba 100644 > --- a/kernel/time/tick-sched.c > +++ b/kernel/time/tick-sched.c > @@ -108,7 +108,6 @@ static ktime_t tick_init_jiffy_update(void) > return period; > } > > - > static void tick_sched_do_timer(ktime_t now) > { > int cpu = smp_processor_id(); > @@ -248,8 +247,8 @@ void tick_nohz_full_kick_all(void) > return; > > preempt_disable(); > - smp_call_function_many(tick_nohz_full_mask, > - nohz_full_kick_ipi, NULL, false); > + smp_call_function_many(tick_nohz_full_mask, nohz_full_kick_ipi, NULL, > + false);
Breaking < 80 char lines is arguable although I'm not sure it still matters in 2014.
But I don't see much the point of the above change. I usually prefer when line contents are a bit balanced. It may be a matter of taste I guess.
| |