Messages in this thread | | | Subject | Re: [PATCHv2 5/9] extcon: max14577: Use devm_extcon_dev_allocate for extcon_dev | From | Krzysztof Kozlowski <> | Date | Tue, 22 Apr 2014 10:18:54 +0200 |
| |
On pon, 2014-04-21 at 21:02 +0900, Chanwoo Choi wrote: > This patch use devm_extcon_dev_allocate() to simplify the memory control > of extcon device. > > Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com> > Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com> > --- > drivers/extcon/extcon-max14577.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-)
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Best regards, Krzysztof
> diff --git a/drivers/extcon/extcon-max14577.c b/drivers/extcon/extcon-max14577.c > index 7221b32..3d24dae 100644 > --- a/drivers/extcon/extcon-max14577.c > +++ b/drivers/extcon/extcon-max14577.c > @@ -668,13 +668,14 @@ static int max14577_muic_probe(struct platform_device *pdev) > } > > /* Initialize extcon device */ > - info->edev = devm_kzalloc(&pdev->dev, sizeof(*info->edev), GFP_KERNEL); > + info->edev = devm_extcon_dev_allocate(&pdev->dev, > + max14577_extcon_cable); > if (!info->edev) { > dev_err(&pdev->dev, "failed to allocate memory for extcon\n"); > return -ENOMEM; > } > info->edev->name = DEV_NAME; > - info->edev->supported_cable = max14577_extcon_cable; > + > ret = devm_extcon_dev_register(&pdev->dev, info->edev); > if (ret) { > dev_err(&pdev->dev, "failed to register extcon device\n");
| |