lkml.org 
[lkml]   [2014]   [Apr]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCHv2 3/9] extcon: max8997: Use devm_extcon_dev_allocate for extcon_dev
From
Date
On pon, 2014-04-21 at 21:02 +0900, Chanwoo Choi wrote:
> This patch use devm_extcon_dev_allocate() to simplify the memory control
> of extcon device.
>
> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
> ---
> drivers/extcon/extcon-max8997.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)

Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

> diff --git a/drivers/extcon/extcon-max8997.c b/drivers/extcon/extcon-max8997.c
> index 804a446..e2ee2f5 100644
> --- a/drivers/extcon/extcon-max8997.c
> +++ b/drivers/extcon/extcon-max8997.c
> @@ -699,8 +699,7 @@ static int max8997_muic_probe(struct platform_device *pdev)
> }
>
> /* External connector */
> - info->edev = devm_kzalloc(&pdev->dev, sizeof(struct extcon_dev),
> - GFP_KERNEL);
> + info->edev = devm_extcon_dev_allocate(&pdev->dev, max8997_extcon_cable);
> if (!info->edev) {
> dev_err(&pdev->dev, "failed to allocate memory for extcon\n");
> ret = -ENOMEM;
> @@ -708,7 +707,7 @@ static int max8997_muic_probe(struct platform_device *pdev)
> }
> info->edev->name = DEV_NAME;
> info->edev->dev.parent = &pdev->dev;
> - info->edev->supported_cable = max8997_extcon_cable;
> +
> ret = devm_extcon_dev_register(&pdev->dev, info->edev);
> if (ret) {
> dev_err(&pdev->dev, "failed to register extcon device\n");



\
 
 \ /
  Last update: 2014-04-22 10:41    [W:0.177 / U:0.452 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site