lkml.org 
[lkml]   [2014]   [Apr]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] mm/swap: cleanup *lru_cache_add* functions
On 04/21/2014 12:02 PM, Jianyu Zhan wrote:
> Hi, Yanfei,
>
> On Mon, Apr 21, 2014 at 9:00 AM, Zhang Yanfei
> <zhangyanfei@cn.fujitsu.com> wrote:
>> What should be exported?
>>
>> lru_cache_add()
>> lru_cache_add_anon()
>> lru_cache_add_file()
>>
>> It seems you only export lru_cache_add_file() in the patch.
>
> Right, lru_cache_add_anon() is only used by VM code, so it should not
> be exported.
>
> lru_cache_add_file() and lru_cache_add() are supposed to be used by
> vfs ans fs code.
>
> But now only lru_cache_add_file() is used by CIFS and FUSE, which
> both could be
> built as module, so it must be exported; and lru_cache_add() has now
> no module users,
> so as Rik suggests, it is unexported too.
>

OK. So The sentence in the patch log confused me:

[ However, lru_cache_add() is supposed to
be used by vfs, or whatever others, but it is not exported.]

otherwise,
Reviewed-by: Zhang Yanfei <zhangyanfei@cn.fujitsu.com>

Thanks.

--
Thanks.
Zhang Yanfei


\
 
 \ /
  Last update: 2014-04-21 08:41    [W:0.058 / U:0.752 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site