Messages in this thread | | | From | Jianyu Zhan <> | Date | Mon, 21 Apr 2014 12:02:42 +0800 | Subject | Re: [PATCH] mm/swap: cleanup *lru_cache_add* functions |
| |
Hi, Yanfei,
On Mon, Apr 21, 2014 at 9:00 AM, Zhang Yanfei <zhangyanfei@cn.fujitsu.com> wrote: > What should be exported? > > lru_cache_add() > lru_cache_add_anon() > lru_cache_add_file() > > It seems you only export lru_cache_add_file() in the patch.
Right, lru_cache_add_anon() is only used by VM code, so it should not be exported.
lru_cache_add_file() and lru_cache_add() are supposed to be used by vfs ans fs code.
But now only lru_cache_add_file() is used by CIFS and FUSE, which both could be built as module, so it must be exported; and lru_cache_add() has now no module users, so as Rik suggests, it is unexported too.
Thanks, Jianyu Zhan
| |