lkml.org 
[lkml]   [2014]   [Apr]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC PATCH 1/5] KVM: vmx: speed up emulation of invalid guest state
Il 20/04/2014 22:13, Marcelo Tosatti ha scritto:
> The same code which resets it to false inside the
> handle_invalid_guest_state loop (so you would stop emulating
> at the same point as you do with this patch).

So (barring any bugs where we fail to set vmx->emulation_required to
true) the "vmx->emulation_required = true;" on vmentry error would be
dead code.

> Advantage would be that failure to set vmx->emulation_required to
> true would not cause VM-entry failure.

A place where we fail to set vmx->emulation_required to true is quite
likely to also be wrong when setting vmx->emulation_required to false.
Since this is not something that has ever seen much churn, I think it's
better to code it in a way that shows bugs easily. The bugs do not
affect the host anyway.

Paolo


\
 
 \ /
  Last update: 2014-04-22 05:41    [W:0.071 / U:0.000 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site