Messages in this thread | | | Date | Sun, 20 Apr 2014 23:13:33 -0300 | From | Marcelo Tosatti <> | Subject | Re: [RFC PATCH 1/5] KVM: vmx: speed up emulation of invalid guest state |
| |
On Fri, Apr 18, 2014 at 12:19:28AM -0400, Paolo Bonzini wrote: > Il 16/04/2014 18:52, Marcelo Tosatti ha scritto: > >How about handling VM-entry error due to invalid state with > > > >vmx->emulation_required = true; > >continue to main vcpu loop; > > What would reset it to false though? None of the places that call > emulation_required() is a hot path right now, and this patch doesn't > add any.
The same code which resets it to false inside the handle_invalid_guest_state loop (so you would stop emulating at the same point as you do with this patch).
Advantage would be that failure to set vmx->emulation_required to true would not cause VM-entry failure.
| |