Messages in this thread | | | Date | Thu, 17 Apr 2014 20:52:58 +0200 | From | Jiri Olsa <> | Subject | Re: [PATCH 0/3] perf top/tui: Fixes for percentage filter behavior |
| |
On Thu, Apr 17, 2014 at 10:38:19PM +0900, Namhyung Kim wrote: > Hi Jiri, > > 2014-04-17 (목), 14:00 +0200, Jiri Olsa: > > On Thu, Apr 17, 2014 at 04:53:23PM +0900, Namhyung Kim wrote: > > > Hi, > > > > > > This is a small fixes for a bug in perf top I found during some tests. > > > It gets segfault if symbol filter found no entries - accessing NULL > > > pointer in that case. > > > > yep, I hit that yesterday as well, but I ended up just with > > the patch below, your changes seems more comprehensive ;-) > > going to review.. > > Well, the end result will be same, but I think it should have 0 > nr_entries when there's no entry to show.
also I hit another issue ;-)
- running report on data with callchains, and the screen is populated to the middle - press 'END' key and the cursor goes to the bottom of the screen (I can tell based on the scrollbar), but there are no entries
I could make the cursor appear by pressing UP arrow, I bisected to: f214833 perf report: Add --percentage option
not sure where's the problem
thanks, jirka -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |