lkml.org 
[lkml]   [2014]   [Apr]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 0/3] perf top/tui: Fixes for percentage filter behavior
    From
    Date
    Hi Jiri,

    2014-04-17 (목), 14:00 +0200, Jiri Olsa:
    > On Thu, Apr 17, 2014 at 04:53:23PM +0900, Namhyung Kim wrote:
    > > Hi,
    > >
    > > This is a small fixes for a bug in perf top I found during some tests.
    > > It gets segfault if symbol filter found no entries - accessing NULL
    > > pointer in that case.
    >
    > yep, I hit that yesterday as well, but I ended up just with
    > the patch below, your changes seems more comprehensive ;-)
    > going to review..

    Well, the end result will be same, but I think it should have 0
    nr_entries when there's no entry to show.

    Thanks,
    Namhyung


    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2014-04-17 16:21    [W:3.013 / U:0.388 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site