Messages in this thread | | | Date | Tue, 15 Apr 2014 13:26:41 +0530 | Subject | Re: [PATCH 4/4] regulator: s5m8767: Use same binding for external control as in s2mps11 | From | Sachin Kamat <> |
| |
On 15 April 2014 02:41, Mark Brown <broonie@kernel.org> wrote: > On Mon, Apr 14, 2014 at 10:09:09AM +0200, Krzysztof Kozlowski wrote: > >> - - s5m8767,pmic-ext-control-gpios: (optional) GPIO specifier for one >> + - samsung,ext-control-gpios: (optional) GPIO specifier for one >> GPIO controlling this regulator (enable/disable); This is >> valid only for buck9. > > This is an incompatible change. It's OK to deprecate the old property > but it's bad form to just remove it.
I agree with Mark. Also, there is no need to make it generic.
-- With warm regards, Sachin
| |