lkml.org 
[lkml]   [2014]   [Apr]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 02/15] arm: __NR_syscalls fix
From
On Fri, Apr 11, 2014 at 12:33 PM, Russell King - ARM Linux
<linux@arm.linux.org.uk> wrote:
> On Fri, Apr 11, 2014 at 12:25:38PM +0200, Miklos Szeredi wrote:
>> From: Miklos Szeredi <mszeredi@suse.cz>
>>
>> Signed-off-by: Miklos Szeredi <mszeredi@suse.cz>
>> Cc: Russell King <linux@arm.linux.org.uk>
>> ---
>
> This has me wondering...
>
> (a) what you think it fixes
> (b) whether you tried to build-test this
>
> The ARM instruction set supports 8-bit immediate constants with an even
> power of two shift. 384 fits that (0x180), 382 does not (0x17e), and
> in your following patch, 383 definitely doesn't (0x17f).
>
> Having this constant larger than necessary does not cause any problem
> for the syscall table: we explicitly pad it with calls to sys_ni_syscall
> to make up the difference.

Yes, and the padding will be of wrong length if NR_syscalls is
incorrect (which may be Oopsable?). At least that is my impression
from a casual glance.

Thanks,
Miklos


\
 
 \ /
  Last update: 2014-04-11 14:21    [W:0.292 / U:0.972 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site