Messages in this thread | | | Date | Tue, 01 Apr 2014 11:54:23 -0700 | From | "H. Peter Anvin" <> | Subject | Re: [GIT PULL] x86 LTO changes for v3.15 |
| |
On 03/31/2014 05:33 PM, Linus Torvalds wrote: > > I notice that there seems to be a handful of x86 system calls that > don't use the SYSCALL_DEFINEx() macros to define the system call, some > grepping finds at least ioperm(), modify_ldt(), sigreturn() and > rt_sigreturn(). There are probably others. They should just be > converted to SYSCALL_DEFINEx() while at it. No, x86 doesn't need the > typecasting, but it won't hurt either, and it's good to be consistent. > > I'm not sure why those system calls didn't get converted (other > x86-specific ones like vm86() _have_ gotten converted), maybe there's > some reason for it. But I *think* the reason is "nobody noticed". >
Pretty much. If nothing else, it breaks tracing.
-hpa
| |