Messages in this thread | | | Date | Mon, 31 Mar 2014 18:09:01 -0700 | From | Andi Kleen <> | Subject | Re: [GIT PULL] x86 LTO changes for v3.15 |
| |
> - don't do the __visible as part of asmlinkage, because it really is > conceptually wrong
Ok.
> > - add the visible to the SYSCALL_DEFINEx() macros
I think SYSCALL_DEFINE actually doesn't need it, as the syscall tables are visible in C. Only the syscall table itself needs to be visible.
> and after that I strongly suspect that there will be only a handful of > cases left that are called from assembly language and that aren't > system calls. Things like "printk()" and friends that are really > special. They'd need a few manual "__visible" annotations.
Ok. I think it's more than a handful though.
I'll cook up a patch.
> See above: I can pretty much guarantee that you should *not* need do > any crazy automated sweeps. Because you shouldn't need "__visible" at > the declarations in the header files, only at the definition of the > function, right?
Yes that's right.
-Andi
| |