lkml.org 
[lkml]   [2014]   [Mar]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [GIT PULL] x86 LTO changes for v3.15
>  - don't do the __visible as part of asmlinkage, because it really is
> conceptually wrong

Ok.

>
> - add the visible to the SYSCALL_DEFINEx() macros

I think SYSCALL_DEFINE actually doesn't need it, as the syscall
tables are visible in C. Only the syscall table itself
needs to be visible.


> and after that I strongly suspect that there will be only a handful of
> cases left that are called from assembly language and that aren't
> system calls. Things like "printk()" and friends that are really
> special. They'd need a few manual "__visible" annotations.

Ok. I think it's more than a handful though.

I'll cook up a patch.

> See above: I can pretty much guarantee that you should *not* need do
> any crazy automated sweeps. Because you shouldn't need "__visible" at
> the declarations in the header files, only at the definition of the
> function, right?

Yes that's right.

-Andi


\
 
 \ /
  Last update: 2014-04-01 04:01    [W:0.072 / U:1.272 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site