Messages in this thread Patch in this message | | | From | Daeseok Youn <> | Subject | [PATCH 2/2] staging: cxt1e1: remove redundant memset() call | Date | Mon, 10 Mar 2014 08:56:55 +0900 |
| |
The name array doens't need to set to 0. Because sprintf/snprintf adds a terminating '\0'.
And also it doesn't need to assign name array address to np pointer.
Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com> --- drivers/staging/cxt1e1/linux.c | 8 +++----- 1 files changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/cxt1e1/linux.c b/drivers/staging/cxt1e1/linux.c index 5d7ddd4..efd3eb8 100644 --- a/drivers/staging/cxt1e1/linux.c +++ b/drivers/staging/cxt1e1/linux.c @@ -204,15 +204,13 @@ status_t c4_wq_port_init(mpi_t *pi) { - char name[16], *np; /* NOTE: name of the queue limited by system + char name[16]; /* NOTE: name of the queue limited by system * to 10 characters */ - if (pi->wq_port) return 0; /* already initialized */ - np = name; - memset(name, 0, 16); - sprintf(np, "%s%d", pi->up->devname, pi->portnum); /* IE pmcc4-01) */ + /* IE pmcc4-01 */ + snprintf(name, sizeof(name), "%s%d", pi->up->devname, pi->portnum); #ifdef RLD_RESTART_DEBUG pr_info(">> %s: creating workqueue <%s> for Port %d.\n", -- 1.7.4.4
| |