lkml.org 
[lkml]   [2014]   [Mar]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] [RESEND] score: remove unused CPU_SCORE7 Kconfig parameter
From
Date
On Sun, 2014-03-09 at 04:27 +0800, Lennox Wu wrote:
> 2014-03-09 4:00 GMT+08:00 Paul Bolle <pebolle@tiscali.nl>:
> > In https://lkml.org/lkml/2011/11/12/76 I already reported that this
> > Kconfig symbol was unused. Why can't it be dropped and re-added when
> > code is added to the tree that actually uses it?
>
> Because I don't think droping it is meaningful, since it will be used.

But, again, it isn't used now and hasn't actually been used in years.

> Moreover, the symbol never affect other architectures or subsystems.
> I feel that is not good to brother people to process the unimportant patch.

Sure, this is just a small cleanup. But the scripts people use to see
whether more serious Kconfig related issues have entered the tree will
likely notice CPU_SCORE7. (And those people will have to investigate why
that symbol is unused - which might take quite a bit of work - to
determine what needs to be done about it.) So whenever someone, not
following this thread, runs a script like that the score maintainers
might receive a similar patch again.

And I don't believe that handling a single cleanup patch is particularly
burdensome for the score maintainers.


Paul Bolle



\
 
 \ /
  Last update: 2014-03-08 22:41    [W:0.046 / U:0.080 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site