Messages in this thread | | | Subject | Re: [PATCH 4/4] raid6: Add severity levels to raid6 initialization messages | From | Paul Bolle <> | Date | Sat, 08 Mar 2014 20:14:33 +0100 |
| |
On Sat, 2014-03-08 at 10:58 -0800, Andy Lutomirski wrote: > Some of them are errors; some are not. Annotate them accordingly. > > Signed-off-by: Andy Lutomirski <luto@amacapital.net> > --- > lib/raid6/algos.c | 13 +++++++------ > 1 file changed, 7 insertions(+), 6 deletions(-) > > diff --git a/lib/raid6/algos.c b/lib/raid6/algos.c > [...] > @@ -194,7 +195,7 @@ int __init raid6_select_algo(void) > syndromes = (void *) __get_free_pages(GFP_KERNEL, 1); > > if (!syndromes) { > - printk("raid6: Yikes! No memory available.\n"); > + printk(KERN_ERR "raid6: Yikes! No memory available.\n"); > return -ENOMEM; > } >
Does __get_free_pages() print and error (or similar) when it fails? If so, this printk() could be dropped, couldn't it?
Paul Bolle
| |