lkml.org 
[lkml]   [2014]   [Mar]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH 1/4] mei: Don't log an error when the MEI device is quirked off
Date


> -----Original Message-----
> From: Andy Lutomirski [mailto:luto@amacapital.net]
> Sent: Saturday, March 08, 2014 20:58
> To: linux-kernel@vger.kernel.org
> Cc: trivial@kernel.org; Andy Lutomirski; Winkler, Tomas
> Subject: [PATCH 1/4] mei: Don't log an error when the MEI device is quirked off
>
> If an administrator wants to use MEI, they can search the logs for
> 'mei'. Otherwise they don't need a glaring reminder that their
> hardware doesn't actually support MEI.
>
> Signed-off-by: Andy Lutomirski <luto@amacapital.net>
> ---
> drivers/misc/mei/pci-me.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/misc/mei/pci-me.c b/drivers/misc/mei/pci-me.c
> index ddadd08..809021e 100644
> --- a/drivers/misc/mei/pci-me.c
> +++ b/drivers/misc/mei/pci-me.c
> @@ -127,7 +127,7 @@ static int mei_me_probe(struct pci_dev *pdev, const
> struct pci_device_id *ent)
>
> if (!mei_me_quirk_probe(pdev, ent)) {
> err = -ENODEV;
> - goto end;
> + return err; /* No point in logging an error. */
> }


I would like to have at least some info/debug message logged,
the issue was discovered on specific DELL machines and there is a little worry
that on some systems it can be false positive.

Thanks
Tomas



\
 
 \ /
  Last update: 2014-03-11 11:42    [W:0.099 / U:0.868 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site