lkml.org 
[lkml]   [2014]   [Mar]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] events: Improve the "perf samples too long" warning
Date
The warning is not indicative of an actual problem, especially when
triggered by nmi_watchdog, so lower it to KERN_INFO. While I'm at
it, clarify the message and reference the sysctl that controls it.

Signed-off-by: Andy Lutomirski <luto@amacapital.net>
---
kernel/events/core.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/kernel/events/core.c b/kernel/events/core.c
index 56003c6..245bdc0 100644
--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -263,9 +263,8 @@ void perf_sample_event_took(u64 sample_len_ns)
sysctl_perf_event_sample_rate = max_samples_per_tick * HZ;
perf_sample_period_ns = NSEC_PER_SEC / sysctl_perf_event_sample_rate;

- printk_ratelimited(KERN_WARNING
- "perf samples too long (%lld > %lld), lowering "
- "kernel.perf_event_max_sample_rate to %d\n",
+ printk_ratelimited(KERN_INFO
+ "perf samples are too slow for kernel.perf_cpu_time_max_percent (%lldns > %lldns); lowering kernel.perf_event_max_sample_rate to %d\n",
avg_local_sample_len, allowed_ns,
sysctl_perf_event_sample_rate);

--
1.8.5.3


\
 
 \ /
  Last update: 2014-03-08 19:41    [W:0.922 / U:0.076 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site