lkml.org 
[lkml]   [2014]   [Mar]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] staging: dgap: remove useless cast on kzalloc()
On 03/06/2014 01:17 AM, Daeseok Youn wrote:
>
> coccinelle warning:
> drivers/staging/dgap/dgap.c:782:3-7: WARNING:
> casting value returned by k[cmz]alloc to (char *) is useless.
> drivers/staging/dgap/dgap.c:776:2-16: WARNING:
> casting value returned by k[cmz]alloc to (struct board_t *) is useless.
>
> Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
> ---
> drivers/staging/dgap/dgap.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c
> index cbce457..1adcd13 100644
> --- a/drivers/staging/dgap/dgap.c
> +++ b/drivers/staging/dgap/dgap.c
> @@ -773,13 +773,13 @@ static int dgap_found_board(struct pci_dev *pdev, int id)
>
> /* get the board structure and prep it */
> brd = dgap_Board[dgap_NumBoards] =
> - (struct board_t *) kzalloc(sizeof(struct board_t), GFP_KERNEL);
> + kzalloc(sizeof(struct board_t), GFP_KERNEL);
> if (!brd)
> return -ENOMEM;
>
> /* make a temporary message buffer for the boot messages */
> brd->msgbuf = brd->msgbuf_head =
> - (char *) kzalloc(sizeof(char) * 8192, GFP_KERNEL);
> + kzalloc(sizeof(char) * 8192, GFP_KERNEL);
> if (!brd->msgbuf) {
> kfree(brd);
> return -ENOMEM;
>

I'm pretty sure this has already been fixed up in current staging-next.

Thanks
Mark


\
 
 \ /
  Last update: 2014-03-06 14:41    [W:0.039 / U:0.144 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site