Messages in this thread Patch in this message | | | From | Stephen Warren <> | Subject | [PATCH] mfd: as3722: make FUSE7_REG readable | Date | Tue, 4 Mar 2014 09:50:32 -0700 |
| |
From: Stephen Warren <swarren@nvidia.com>
The FUSE7_REG register is not currently marked readable. This causes as3722_sd0_is_low_voltage() to emit an error during boot, and assume the range of the SD0 regulator:
as3722-regulator as3722-regulator: Reg 0xa7 read failed: -5
Fixes: d4807ad2c4c0 ("regmap: Check readable regs in _regmap_read") [exposed the bug, by checking for readability] Fixes: 762a8ee80897 ("regulator: as3722: detect SD0 low-voltage mode") [left out this register from the readable list] Cc: Mark Brown <broonie@linaro.org> Cc: Michal Simek <michal.simek@xilinx.com> Cc: Andrew Bresticker <abrestic@chromium.org> Cc: Vince Hsu <vinceh@nvidia.com> Signed-off-by: Stephen Warren <swarren@nvidia.com> --- Note: I believe the regmap commit mentioned above is for 3.15, whereas the as3722 commit is in at least 3.14. So, this only needs to be applied for 3.15, but might make sense to go into earlier kernels, at your discretion. --- drivers/mfd/as3722.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/mfd/as3722.c b/drivers/mfd/as3722.c index c71ff0af1547..39fa554f13bb 100644 --- a/drivers/mfd/as3722.c +++ b/drivers/mfd/as3722.c @@ -277,6 +277,7 @@ static const struct regmap_range as3722_readable_ranges[] = { regmap_reg_range(AS3722_ADC0_CONTROL_REG, AS3722_ADC_CONFIGURATION_REG), regmap_reg_range(AS3722_ASIC_ID1_REG, AS3722_ASIC_ID2_REG), regmap_reg_range(AS3722_LOCK_REG, AS3722_LOCK_REG), + regmap_reg_range(AS3722_FUSE7_REG, AS3722_FUSE7_REG), }; static const struct regmap_access_table as3722_readable_table = { -- 1.8.1.5
| |