Messages in this thread Patch in this message | | | Date | Fri, 28 Mar 2014 10:04:06 +0000 | From | Catalin Marinas <> | Subject | Re: [PATCH v3 1/4] kmemleak: free internal objects only if there're no leaks to be reported |
| |
On Fri, Mar 28, 2014 at 08:52:26AM +0000, Li Zefan wrote: > Currently if you disabling kmemleak after stopping kmemleak thread, > kmemleak objects will be freed and so you won't be able to check > previously reported leaks. > > With this patch, kmemleak objects won't be freed if there're leaks > that can be reported. > > Signed-off-by: Li Zefan <lizefan@huawei.com>
Some nitpicks below:
> diff --git a/mm/kmemleak.c b/mm/kmemleak.c > index 31f01c5..be7ecc0 100644 > --- a/mm/kmemleak.c > +++ b/mm/kmemleak.c > @@ -218,7 +218,8 @@ static int kmemleak_stack_scan = 1; > static DEFINE_MUTEX(scan_mutex); > /* setting kmemleak=on, will set this var, skipping the disable */ > static int kmemleak_skip_disable; > - > +/* If there're leaks that can be reported */
"If there are ..." (easier to read ;)).
> +static bool kmemleak_has_leaks;
Better "kmemleak_found_leaks" to avoid confusion.
Otherwise:
Acked-by: Catalin Marinas <catalin.marinas@arm.com>
| |