Messages in this thread | | | Date | Fri, 28 Mar 2014 18:22:32 +0800 | From | Li Zefan <> | Subject | Re: [PATCH v3 2/4] kmemleak: allow freeing internal objects after kmemleak was disabled |
| |
>> + if (!kmemleak_has_leaks) >> + __kmemleak_do_cleanup(); >> + else >> + pr_info("Disable kmemleak without freeing internal objects, " >> + "so you may still check information on memory leaks. " >> + "You may reclaim memory by writing \"clear\" to " >> + "/sys/kernel/debug/kmemleak\n"); > > Alternative text: > > pr_info("Kmemleak disabled without freeing internal data. " > "Reclaim the memory with \"echo clear > /sys/kernel/debug/kmemleak\"\n"); > > (I'm wouldn't bother with long lines in printk strings) > > Otherwise: > > Acked-by: Catalin Marinas <catalin.marinas@arm.com> >
Thanks for the review!
| |