Messages in this thread Patch in this message | | | From | Monam Agarwal <> | Subject | [PATCH] block: Use RCU_INIT_POINTER(x, NULL) in genhd.c | Date | Sun, 23 Mar 2014 02:00:18 +0530 |
| |
This patch replaces rcu_assign_pointer(x, NULL) with RCU_INIT_POINTER(x, NULL)
The rcu_assign_pointer() ensures that the initialization of a structure is carried out before storing a pointer to that structure. And in the case of the NULL pointer, there is no structure to initialize. So, rcu_assign_pointer(p, NULL) can be safely converted to RCU_INIT_POINTER(p, NULL)
Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com> --- block/genhd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/genhd.c b/block/genhd.c index 791f419..3aec057 100644 --- a/block/genhd.c +++ b/block/genhd.c @@ -1045,7 +1045,7 @@ static void disk_replace_part_tbl(struct gendisk *disk, rcu_assign_pointer(disk->part_tbl, new_ptbl); if (old_ptbl) { - rcu_assign_pointer(old_ptbl->last_lookup, NULL); + RCU_INIT_POINTER(old_ptbl->last_lookup, NULL); kfree_rcu(old_ptbl, rcu_head); } } -- 1.7.9.5
| |