Messages in this thread | | | From | Rasmus Villemoes <> | Subject | Comment added in 63662139e "params: Fix potential memory leak in add_sysfs_param()" | Date | Fri, 21 Mar 2014 13:46:56 +0100 |
| |
Hi,
I'm not at all convinced by the comment added in commit 63662139e519ce. If krealloc(attrs, ...) fails, nothing seems to free attrs; the krealloc() call certainly doesn't do it. If attrs was NULL to begin with, no harm done, but otherwise it is "attrs = mk->mp->grp.attrs;", and mk->mp is NULL'ed on the error path fail_free_new: (and the value of mk->mp is anyway invalidated by the krealloc() above).
Am I missing something?
Rasmus
| |