lkml.org 
[lkml]   [2014]   [Mar]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 09/11] bluetooth: hci_ldisc: fix deadlock condition
On Thu, Mar 20, 2014 at 12:40:40PM -0700, Marcel Holtmann wrote:
> Hi Felipe,
>
> > LDISCs shouldn't call tty->ops->write() from within
> > ->write_wakeup().
> >
> > ->write_wakeup() is called with port lock taken and
> > IRQs disabled, tty->ops->write() will try to acquire
> > the same port lock and we will deadlock.
> >
> > Reviewed-by: Peter Hurley <peter@hurleysoftware.com>
> > Reported-by: Huang Shijie <b32955@freescale.com>
> > Signed-off-by: Felipe Balbi <balbi@ti.com>
> > ---
> > drivers/bluetooth/hci_ldisc.c | 24 +++++++++++++++++++-----
> > drivers/bluetooth/hci_uart.h | 1 +
> > 2 files changed, 20 insertions(+), 5 deletions(-)
>
> I hope these are not causing any conflicts with bluetooth-next /
> linux-next. If not, then I can let Greg take it through tty-next tree.
>
> Acked-by: Marcel Holtmann <marcel@holtmann.org>

tty-next is already closed, i'll rebase (if necessary) once -rc1 is out
;-)

cheers

--
balbi
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2014-03-20 22:01    [W:0.222 / U:0.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site