Messages in this thread | | | Date | Sun, 02 Mar 2014 10:11:24 +0100 | From | Lars-Peter Clausen <> | Subject | Re: [iio:togreg 3/3] WARNING: Reusing the krealloc arg is almost always a bug |
| |
On 03/02/2014 03:24 AM, Fengguang Wu wrote: > > Hi Lars-Peter, > > FYI, there are new warnings show up in > > tree: git://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg > head: bdc8cda1d010887c06bd8c29564b74cd61ec0a7b > commit: bdc8cda1d010887c06bd8c29564b74cd61ec0a7b [3/3] iio:adc: Add Xilinx XADC driver > > scripts/checkpatch.pl 0001-iio-adc-Add-Xilinx-XADC-driver.patch > # many are suggestions rather than must-fix > WARNING: Reusing the krealloc arg is almost always a bug > #1220: drivers/iio/adc/xilinx-xadc-core.c:1138: > + indio_dev->channels = krealloc(channels, sizeof(*channels) * >
This is actually a false positive, checkpatch thinks that 'indio_dev->channels' and 'channels' is the same. Added Joe to Cc.
- Lars
| |