Messages in this thread Patch in this message | | | From | Patrick Palka <> | Subject | [PATCH] perf bench: Fix NULL pointer dereference in "perf bench all" | Date | Wed, 12 Mar 2014 18:40:51 -0400 |
| |
for_each_bench() must check that the "benchmarks" field of a collection is not NULL before dereferencing it because the "all" collection in particular has a NULL "benchmarks" field (signifying that it has no benchmarks to iterate over).
This fixes a NULL pointer dereference when running "perf bench all".
Signed-off-by: Patrick Palka <patrick@parcs.ath.cx> --- tools/perf/builtin-bench.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/builtin-bench.c b/tools/perf/builtin-bench.c index e47f90c..8a987d2 100644 --- a/tools/perf/builtin-bench.c +++ b/tools/perf/builtin-bench.c @@ -76,7 +76,7 @@ static struct collection collections[] = { /* Iterate over all benchmarks within a collection: */ #define for_each_bench(coll, bench) \ - for (bench = coll->benchmarks; bench->name; bench++) + for (bench = coll->benchmarks; bench && bench->name; bench++) static void dump_benchmarks(struct collection *coll) { -- 1.9.0
| |