Messages in this thread | | | Date | Wed, 12 Mar 2014 07:58:37 +0100 | From | Christian Riesch <> | Subject | Re: [PATCH RFC net-next v1 0/9] ptp: dynamic pin control |
| |
Hi Richard,
--On March 10, 2014 14:42 +0100 Richard Cochran <richardcochran@gmail.com> wrote:
> On Mon, Mar 10, 2014 at 12:52:57PM +0000, Sørensen, Stefan wrote: >> >> What are the n_ext_ts and n_per_out supposed to be set to now? The >> number of pins configured for the relevant function or the number of >> channels that are available for the function? > > They are the number of available functions. This is not necessarily the > same as the number of pins. Many chips have more functions than pins. > >> The implementation is limited to a single function for each pin - the >> dp83640 supports an ext_ts and several periodic outputs on the same pin, >> but I do not see that many real-world uses. > > Yes, it does support different functions on a single pin, but not at > the same time. You have to choose what function you want on each pin, > and that is what the new ioctl lets you do. > > I did not change the n_per_out in this series,
Why not? I think it would be a good idea to set both n_ext_ts and n_per_out to the correct value right from the start (8, right?). Christian
> but once this basic > support gets merged, then you will be able to increase n_per_out for > the dp83640 with little extra effort. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |