Messages in this thread | | | Date | Mon, 3 Feb 2014 13:59:19 -0800 | Subject | Re: [PATCH v2] ceph: fix posix ACL hooks | From | Linus Torvalds <> |
| |
On Mon, Feb 3, 2014 at 1:03 PM, Linus Torvalds <torvalds@linux-foundation.org> wrote: > > What do you think? I guess this patch could be split up into two: one > that does the "vfs_xyz()" helper functions, and another that does the > inode_permission() change. I tied them together mainly because I > started with the inode_permission() change, and that required the > vfs_xyz() change.
Ok, this is the split-up. I haven't completed the "make allmodconfig" for the first patch yet, so I might have split this wrong, but it was fairly well separated and I'm pretty sure that this is fine.
I do actually agree that the second patch isn't exactly pretty. Passing in both dentry and inode is redundant, and calling the function "inode_permission()" is now a misnomer. But it makes it a lot easier to see the differences this way in the diff (particularly word-diff), so I think a renaming and/or dropping the inode parameter would better be done as a separate patch anyway.
And no, as far as the first patch is concerned, I certainly wouldn't hate dropping the first 'parent' argument from the vfs_xyzzy() functions either, since that *should* be redundant, but quite frankly, I didn't want to think too much about that, and this was the simple conversions (and all callers were quite happy with dropping the inode and replacing it with the dentry).
Linus [unhandled content-type:application/octet-stream][unhandled content-type:application/octet-stream] | |