lkml.org 
[lkml]   [2014]   [Feb]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 3.13 35/99] tty: Set correct tty name in active sysfs attribute
Hi,

(resending because my phone tried to send the reply as html mail and
it got rejected)

On Sat, Feb 22, 2014 at 9:27 AM, David Herrmann <dh.herrmann@gmail.com> wrote:
> > How about this:
>
> + driver = cs[i]->device(cs[i], &index);
> + /* special case for tty0 which must not be resolved */
> + if (driver && (index > 0 || cs[i]->major != TTY_MAJOR)) {
> + count += tty_line_name(driver, index, buf + count);
> + count += sprintf(buf + count, "%c", i ? ' ':'\n');
> + } else
> + count += sprintf(buf + count, "%s%d%c",
> + name, index, i ? ' ':'\n');
Assuming I'm reading the code correctly, I don't think that will work.
Index will be rewritten from 0 to fg_console (which I suppose is
going to be 1) after the device vfunc is called.

--Ray


\
 
 \ /
  Last update: 2014-02-23 02:01    [W:1.222 / U:0.420 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site