Messages in this thread | | | Date | Sun, 23 Feb 2014 16:05:25 +0100 | Subject | Re: [PATCH 3.13 35/99] tty: Set correct tty name in active sysfs attribute | From | David Herrmann <> |
| |
Hi
On Sun, Feb 23, 2014 at 1:20 AM, Ray Strode <halfline@gmail.com> wrote: > Hi, > > > On Feb 22, 2014 9:27 AM, "David Herrmann" <dh.herrmann@gmail.com> wrote: >> How about this: >> >> + driver = cs[i]->device(cs[i], &index); >> + /* special case for tty0 which must not be resolved */ >> + if (driver && (index > 0 || cs[i]->major != TTY_MAJOR)) { >> + count += tty_line_name(driver, index, buf + >> count); >> + count += sprintf(buf + count, "%c", i ? ' ':'\n'); >> + } else >> + count += sprintf(buf + count, "%s%d%c", >> + name, index, i ? ' ':'\n'); > > Assuming I'm reading the code correctly, I don't think that will work. > Index will be rewritten from 0 to fg_console (which I suppose is going to be > 1) after the device vfunc is called.
Oh, nice catch. We have to use cs[i]->index of course. I only hand-edited the patch, I didn't even compile-test. But I guess you get the idea of special-casing tty0.
Thanks David
| |