Messages in this thread | | | Date | Wed, 19 Feb 2014 19:19:31 +0000 | From | Zoltan Kiss <> | Subject | Re: [PATCH net-next v5 1/9] xen-netback: Introduce TX grant map definitions |
| |
On 18/02/14 17:24, Ian Campbell wrote: > On Mon, 2014-01-20 at 21:24 +0000, Zoltan Kiss wrote: >> >> + spinlock_t dealloc_lock; >> + spinlock_t response_lock; > > Please add comments to both of these describing what bits of the > datastructure they are locking. > > You might find it is clearer to group the locks and the things they > protect together rather than grouping the locks together.
Ok, I'll give more description here. The response_lock is actually quite relevant to be here, but indeed that's not obvious, I'll explain that as well.
Zoli
| |